Dwinzo-Beta/Dwinzo_Demo
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix:

Browse Source 
- react-hooks/exhaustive-deps added
- style update
- key fix
This commit is contained in:
Vishnu
2025-08-25 16:22:41 +05:30
parent affffe09c8
commit 246236c15f
4 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/components/layout/sidebarRight/properties/AssetProperties.tsx
View File

@@ -78,8 +78,8 @@ const AssetProperties: React.FC = () => {
<section> <section>
<div className="header">User Data</div> <div className="header">User Data</div>
{userData.map((data) => ( {userData.map((data, i) => (
<div className="input-container"> <div className="input-container" key={i}>
<InputWithDropDown <InputWithDropDown
key={data.id} key={data.id}
label={data.label} label={data.label}

3
app/src/modules/scene/controls/selectionControls/selection3D/moveControls3D.tsx
View File

@@ -64,6 +64,7 @@ function MoveControls3D({ boundingBoxRef }: any) {
setContextAction(null); setContextAction(null);
moveAssets() moveAssets()
} }
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [contextAction]) }, [contextAction])
useEffect(() => { useEffect(() => {
@@ -176,6 +177,7 @@ function MoveControls3D({ boundingBoxRef }: any) {
canvasElement.removeEventListener("keydown", onKeyDown); canvasElement.removeEventListener("keydown", onKeyDown);
canvasElement?.removeEventListener("keyup", onKeyUp); canvasElement?.removeEventListener("keyup", onKeyUp);
}; };
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [camera, controls, scene, toggleView, selectedAssets, socket, pastedObjects, duplicatedObjects, movedObjects, rotatedObjects, keyEvent, initialStates]); }, [camera, controls, scene, toggleView, selectedAssets, socket, pastedObjects, duplicatedObjects, movedObjects, rotatedObjects, keyEvent, initialStates]);
const calculateDragOffset = useCallback((point: THREE.Object3D, hitPoint: THREE.Vector3) => { const calculateDragOffset = useCallback((point: THREE.Object3D, hitPoint: THREE.Vector3) => {
@@ -223,6 +225,7 @@ function MoveControls3D({ boundingBoxRef }: any) {
setDragOffset(newOffset); setDragOffset(newOffset);
} }
} }
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [axisConstraint, camera, movedObjects]) }, [axisConstraint, camera, movedObjects])
useFrame(() => { useFrame(() => {

5
app/src/modules/scene/controls/selectionControls/selection3D/selectionControls3D.tsx
View File

@@ -67,6 +67,7 @@ const SelectionControls3D: React.FC = () => {
setContextAction(null); setContextAction(null);
deleteSelection() deleteSelection()
} }
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [contextAction]) }, [contextAction])
useEffect(() => { useEffect(() => {
@@ -222,12 +223,14 @@ const SelectionControls3D: React.FC = () => {
helper.enabled = false; helper.enabled = false;
helper.dispose(); helper.dispose();
}; };
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [camera, controls, scene, toggleView, selectedAssets, copiedObjects, pastedObjects, duplicatedObjects, movedObjects, socket, rotatedObjects, activeModule, toolMode]); }, [camera, controls, scene, toggleView, selectedAssets, copiedObjects, pastedObjects, duplicatedObjects, movedObjects, socket, rotatedObjects, activeModule, toolMode]);
useEffect(() => { useEffect(() => {
if (activeModule !== "builder" || toolMode !== 'cursor' || toggleView) { if (activeModule !== "builder" || toolMode !== 'cursor' || toggleView) {
clearSelection(); clearSelection();
} }
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [activeModule, toolMode, toggleView]); }, [activeModule, toolMode, toggleView]);
const selectAssets = useCallback(() => { const selectAssets = useCallback(() => {
@@ -362,7 +365,7 @@ const SelectionControls3D: React.FC = () => {
removeAsset(uuid); removeAsset(uuid);
}); });
echo.success("Selected models removed!"); echo.warn("Selected models removed!");
clearSelection(); clearSelection();
} }
}; };

1
app/src/styles/components/form.scss
View File

@@ -9,6 +9,7 @@
border-radius: #{$border-radius-large}; border-radius: #{$border-radius-large};
outline: 1px solid var(--border-color); outline: 1px solid var(--border-color);
z-index: 100; z-index: 100;
backdrop-filter: blur(4px);
.header { .header {
@include flex-center; @include flex-center;
gap: 8px; gap: 8px;