From 246236c15fe085cdca5fb007a3f04594b69d4d14 Mon Sep 17 00:00:00 2001 From: Vishnu Date: Mon, 25 Aug 2025 16:22:41 +0530 Subject: [PATCH] fix: - react-hooks/exhaustive-deps added - style update - key fix --- .../layout/sidebarRight/properties/AssetProperties.tsx | 4 ++-- .../selectionControls/selection3D/moveControls3D.tsx | 3 +++ .../selectionControls/selection3D/selectionControls3D.tsx | 5 ++++- app/src/styles/components/form.scss | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/app/src/components/layout/sidebarRight/properties/AssetProperties.tsx b/app/src/components/layout/sidebarRight/properties/AssetProperties.tsx index 5d0a97c..a62abda 100644 --- a/app/src/components/layout/sidebarRight/properties/AssetProperties.tsx +++ b/app/src/components/layout/sidebarRight/properties/AssetProperties.tsx @@ -78,8 +78,8 @@ const AssetProperties: React.FC = () => {
User Data
- {userData.map((data) => ( -
+ {userData.map((data, i) => ( +
{ @@ -176,6 +177,7 @@ function MoveControls3D({ boundingBoxRef }: any) { canvasElement.removeEventListener("keydown", onKeyDown); canvasElement?.removeEventListener("keyup", onKeyUp); }; + // eslint-disable-next-line react-hooks/exhaustive-deps }, [camera, controls, scene, toggleView, selectedAssets, socket, pastedObjects, duplicatedObjects, movedObjects, rotatedObjects, keyEvent, initialStates]); const calculateDragOffset = useCallback((point: THREE.Object3D, hitPoint: THREE.Vector3) => { @@ -223,6 +225,7 @@ function MoveControls3D({ boundingBoxRef }: any) { setDragOffset(newOffset); } } + // eslint-disable-next-line react-hooks/exhaustive-deps }, [axisConstraint, camera, movedObjects]) useFrame(() => { diff --git a/app/src/modules/scene/controls/selectionControls/selection3D/selectionControls3D.tsx b/app/src/modules/scene/controls/selectionControls/selection3D/selectionControls3D.tsx index 1dab7bc..ed458c2 100644 --- a/app/src/modules/scene/controls/selectionControls/selection3D/selectionControls3D.tsx +++ b/app/src/modules/scene/controls/selectionControls/selection3D/selectionControls3D.tsx @@ -67,6 +67,7 @@ const SelectionControls3D: React.FC = () => { setContextAction(null); deleteSelection() } + // eslint-disable-next-line react-hooks/exhaustive-deps }, [contextAction]) useEffect(() => { @@ -222,12 +223,14 @@ const SelectionControls3D: React.FC = () => { helper.enabled = false; helper.dispose(); }; + // eslint-disable-next-line react-hooks/exhaustive-deps }, [camera, controls, scene, toggleView, selectedAssets, copiedObjects, pastedObjects, duplicatedObjects, movedObjects, socket, rotatedObjects, activeModule, toolMode]); useEffect(() => { if (activeModule !== "builder" || toolMode !== 'cursor' || toggleView) { clearSelection(); } + // eslint-disable-next-line react-hooks/exhaustive-deps }, [activeModule, toolMode, toggleView]); const selectAssets = useCallback(() => { @@ -362,7 +365,7 @@ const SelectionControls3D: React.FC = () => { removeAsset(uuid); }); - echo.success("Selected models removed!"); + echo.warn("Selected models removed!"); clearSelection(); } }; diff --git a/app/src/styles/components/form.scss b/app/src/styles/components/form.scss index 67accd2..31b9015 100644 --- a/app/src/styles/components/form.scss +++ b/app/src/styles/components/form.scss @@ -9,6 +9,7 @@ border-radius: #{$border-radius-large}; outline: 1px solid var(--border-color); z-index: 100; + backdrop-filter: blur(4px); .header { @include flex-center; gap: 8px;