Dwinzo-Beta
/
Dwinzo_dev
4
0
Fork 3
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: optimize ArrowOnQuadraticBezier to improve curve calculations and simplify subCurve generation

This commit is contained in:
Jerald-Golden-B 2025-05-21 10:05:17 +05:30
parent 88d6c48c1d
commit 402223feb3
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/src/modules/simulation/events/arrows/arrows.tsx
View File

@ -160,29 +160,26 @@ export function ArrowOnQuadraticBezier({
const arrowRadius = 0.01 * scale; const arrowRadius = 0.01 * scale;
const arrowHeadRadius = arrowRadius * 2.5; const arrowHeadRadius = arrowRadius * 2.5;
const curveLength = useMemo(() => fullCurve.getLength(), [fullCurve]);
const arrowHeadTOffset = useMemo(() => Math.min(arrowHeadLength / curveLength, 0.5), [arrowHeadLength, curveLength]);
const endT = 1 - arrowHeadTOffset;
const subCurve = useMemo(() => { const subCurve = useMemo(() => {
const t1 = Math.max(0, endT - segmentSize / 2); const centerT = 0.5;
const t2 = Math.min(1, endT + segmentSize / 2); const t1 = Math.max(0, centerT - segmentSize / 2);
const t2 = Math.min(1, centerT + segmentSize / 2);
const divisions = 10; const divisions = 10;
const subPoints = Array.from({ length: divisions + 1 }, (_, i) => { const subPoints = Array.from({ length: divisions + 1 }, (_, i) => {
const t = THREE.MathUtils.lerp(t1, t2, i / divisions); const t = THREE.MathUtils.lerp(t1, t2, i / divisions);
return fullCurve.getPoint(t); return fullCurve.getPoint(t);
}); });
return new THREE.CatmullRomCurve3(subPoints); return new THREE.CatmullRomCurve3(subPoints);
}, [fullCurve, endT, segmentSize]); }, [fullCurve, segmentSize]);
const tubeGeometry = useMemo( const tubeGeometry = useMemo(
() => new THREE.TubeGeometry(subCurve, 20, arrowRadius, 8, false), () => new THREE.TubeGeometry(subCurve, 20, arrowRadius, 8, false),
[subCurve, arrowRadius] [subCurve, arrowRadius]
); );
const arrowPosition = useMemo(() => fullCurve.getPoint(1), [fullCurve]); const arrowPosition = useMemo(() => subCurve.getPoint(1), [subCurve]);
const arrowTangent = useMemo(() => fullCurve.getTangent(1).normalize(), [fullCurve]); const arrowTangent = useMemo(() => subCurve.getTangent(1).normalize(), [subCurve]);
const arrowRotation = useMemo(() => { const arrowRotation = useMemo(() => {
return new THREE.Quaternion().setFromUnitVectors(new THREE.Vector3(0, 1, 0), arrowTangent); return new THREE.Quaternion().setFromUnitVectors(new THREE.Vector3(0, 1, 0), arrowTangent);