From d80d5ae16159cfe27df6762cfb5e8fbf26344ec3 Mon Sep 17 00:00:00 2001
From: Vishnu <vishnu@hexrfactory.com>
Date: Tue, 10 Jun 2025 14:55:23 +0530
Subject: [PATCH] refactor: Update response message checks and improve zone
 name duplication logic across components

---
 app/src/components/layout/sidebarLeft/SideBarLeft.tsx    | 3 ---
 .../layout/sidebarRight/properties/ZoneProperties.tsx    | 9 ++++-----
 app/src/components/ui/list/List.tsx                      | 7 +++----
 3 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/app/src/components/layout/sidebarLeft/SideBarLeft.tsx b/app/src/components/layout/sidebarLeft/SideBarLeft.tsx
index 30f4778..8fd5bea 100644
--- a/app/src/components/layout/sidebarLeft/SideBarLeft.tsx
+++ b/app/src/components/layout/sidebarLeft/SideBarLeft.tsx
@@ -33,9 +33,6 @@ const SideBarLeft: React.FC = () => {
     console.log(value);
   };
 
-  console.log('isVersionSaved: ', isVersionSaved);
-  console.log('toggleUILeft: ', toggleUILeft);
-
   return (
     <div
       className={`sidebar-left-wrapper ${toggleUILeft && (!isVersionSaved || activeModule !== "simulation") ? "open" : "closed"
diff --git a/app/src/components/layout/sidebarRight/properties/ZoneProperties.tsx b/app/src/components/layout/sidebarRight/properties/ZoneProperties.tsx
index 2cad712..2f7a20f 100644
--- a/app/src/components/layout/sidebarRight/properties/ZoneProperties.tsx
+++ b/app/src/components/layout/sidebarRight/properties/ZoneProperties.tsx
@@ -37,7 +37,7 @@ const ZoneProperties: React.FC = () => {
 
       let response = await zoneCameraUpdate(zonesdata, organization,projectId);
       console.log('response: ', response);
-      if (response.message === "updated successfully") {
+      if (response.message === "zone updated") {
         setEdit(false);
       } else {
         // console.log(response);
@@ -60,9 +60,8 @@ const ZoneProperties: React.FC = () => {
     };
     // Call your API to update the zone
     let response = await zoneCameraUpdate(zonesdata, organization,projectId);
-    console.log('response: ', response);
-    // console.log("response: ", response);
-    if (response.message === "updated successfully") {
+    setSelectedZone((prev) => ({ ...prev, zoneName: newName }));
+    if (response.message === "zone updated") {
       setZones((prevZones: any[]) =>
         prevZones.map((zone) =>
           zone.zoneUuid === selectedZone.zoneUuid
@@ -83,7 +82,7 @@ const ZoneProperties: React.FC = () => {
   const checkZoneNameDuplicate = (name: string) => {
     return zones.some(
       (zone: any) =>
-        zone.zoneName.trim().toLowerCase() === name.trim().toLowerCase() &&
+        zone.zoneName?.trim().toLowerCase() === name?.trim().toLowerCase() &&
         zone.zoneUuid !== selectedZone.zoneUuid
     );
   };
diff --git a/app/src/components/ui/list/List.tsx b/app/src/components/ui/list/List.tsx
index 8136a18..09087cd 100644
--- a/app/src/components/ui/list/List.tsx
+++ b/app/src/components/ui/list/List.tsx
@@ -18,7 +18,6 @@ import {
 } from "../../../store/builder/store";
 import { zoneCameraUpdate } from "../../../services/visulization/zone/zoneCameraUpdation";
 import { setFloorItemApi } from "../../../services/factoryBuilder/assest/floorAsset/setFloorItemApi";
-import OuterClick from "../../../utils/outerClick";
 import { useParams } from "react-router-dom";
 import { useAssetsStore } from "../../../store/builder/useAssetStore";
 
@@ -111,7 +110,7 @@ const List: React.FC<ListProps> = ({ items = [], remove }) => {
 
     const isDuplicate = zones.some(
       (zone: any) =>
-        zone.zoneName.trim().toLowerCase() === newName.trim().toLowerCase() &&
+        zone.zoneName?.trim().toLowerCase() === newName?.trim().toLowerCase() &&
         zone.zoneUuid !== selectedZone.zoneUuid
     );
 
@@ -127,7 +126,7 @@ const List: React.FC<ListProps> = ({ items = [], remove }) => {
 
     const response = await zoneCameraUpdate(zonesdata, organization,projectId);
     console.log('response: ', response);
-    if (response.message === "updated successfully") {
+    if (response.message === "zone updated") {
       setSelectedZone((prev) => ({ ...prev, zoneName: newName }));
 
       setZones((prevZones: any[]) =>
@@ -158,7 +157,7 @@ const List: React.FC<ListProps> = ({ items = [], remove }) => {
   const checkZoneNameDuplicate = (name: string) => {
     return zones.some(
       (zone: any) =>
-        zone.zoneName.trim().toLowerCase() === name.trim().toLowerCase() &&
+        zone.zoneName?.trim().toLowerCase() === name?.trim().toLowerCase() &&
         zone.zoneUuid !== selectedZone.zoneUuid
     );
   };